Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 2673] Users token stub endpoint #2885

Merged
merged 47 commits into from
Nov 21, 2024
Merged

Conversation

babebe
Copy link
Collaborator

@babebe babebe commented Nov 15, 2024

Summary

Fixes #{2673}

Time to review: 10 mins

Changes proposed

  • Added POST v1/users/user/token endpoint
  • Added UserTokenHeaderSchema, UserTokenResponseSchema , UserTokenSchema, UserSchema
  • Added users blueprint. Register blueprint only when local
  • Added tests

Context for reviewers

This is a stub endpoint that returns an error response if called without the required header. Otherwise it returns a static response

@babebe babebe marked this pull request as draft November 15, 2024 22:10
@babebe babebe marked this pull request as ready for review November 15, 2024 22:18
@babebe babebe linked an issue Nov 15, 2024 that may be closed by this pull request
2 tasks
@babebe babebe requested a review from chouinar November 18, 2024 17:08
@babebe babebe marked this pull request as draft November 18, 2024 19:04
@babebe babebe marked this pull request as ready for review November 20, 2024 18:27
api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
api/src/app.py Outdated Show resolved Hide resolved
api/src/app.py Outdated Show resolved Hide resolved
@babebe babebe requested a review from chouinar November 21, 2024 14:58
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor tidying up suggestions

api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
api/src/api/users/user_routes.py Outdated Show resolved Hide resolved
@babebe babebe requested a review from chouinar November 21, 2024 15:44
Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@babebe babebe merged commit 5ee465d into main Nov 21, 2024
2 checks passed
@babebe babebe deleted the 2673/users-token-sub-endpoint branch November 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create POST /users/token stub endpoint
4 participants